Fix/performance measurer high samples #926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
maximilien-noal
force-pushed
the
fix/performance_measurer_high_samples
branch
from
11162cf to
744e755
Compare
Signed-off-by: Maximilien Noal <noal.maximilien@gmail.com>
JorisVanEijden
approved these changes
Nov 10, 2024
Co-authored-by: Joris van Eijden <joris.vaneijden@gmail.com>
Co-authored-by: Joris van Eijden <joris.vaneijden@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Fixes performances measurements which were incorrectly measured as 0 if samples were given with a time resolution below one millisecond to the PerformanceMeasurer class.
Also makes the EmulationLoop uses the PerformanceMeasurer to record and calculate performance measures, instead of recreating the function by itself.
Rationale behind Changes
Just a small fix I came across.
Suggested Testing Steps
Already tested. Nothing changed.